Skip to content

Fixed event capture from bubbling phase to capturing#463

Open
os-davidlourenco wants to merge 1 commit intosa-si-dev:masterfrom
os-davidlourenco:master
Open

Fixed event capture from bubbling phase to capturing#463
os-davidlourenco wants to merge 1 commit intosa-si-dev:masterfrom
os-davidlourenco:master

Conversation

@os-davidlourenco
Copy link
Contributor

This PR is to change the documentBody click handler from the bubbling phase to the capturing phase

What was happening

  • The capture of a click on the outside of the dropdown when the dropdown is opened was happening at the bubbling phase. For React 17 onwards, this phase is too late to react to the click event.

What was done

  • A option for handling the event at capturing phase was added and set as true for the documentBody event

Copy link
Collaborator

@gnbm gnbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants