fix(deps): patch Rust XML advisory paths#218
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 889c649f01
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| run: | | ||
| set +e | ||
| cargo audit --json > ../cargo-audit.json | ||
| bash ../scripts/security/run-cargo-audit.sh --json > ../cargo-audit.json |
There was a problem hiding this comment.
Guard quick-xml waivers by dependency path
Switching the scheduled Rust audit to the waiver wrapper means the JSON summary is produced after the wrapper's global --ignore RUSTSEC-2026-0194/0195; cargo-audit documents --ignore as ignoring advisory IDs, not dependency paths (docs). I checked this workflow and it does not run the new tests/security/test_rust_dependency_advisories.py path guard, so if a later lockfile update reintroduces quick-xml <0.41 through calamine/plist or another runtime parser, dependency-watch can suppress the alert even though the waiver is intended only for wayland-scanner. Run the path guard here or make the wrapper fail when the ignored quick-xml advisories appear outside the trusted build-time chain.
Useful? React with 👍 / 👎.
What
Why
How
Testing
Performance impact
Risk / Notes
Screenshots (UI only)
Lockfile rationale (if lockfile changed)