fix(security): raise the postcss override past its own ceiling - #38
Merged
Conversation
The overrides block pinned postcss to exactly 8.5.10, forcing that version into all three consumers that pull it in: @tailwindcss/postcss, next, and vite. That pin was added by "fix: patch decisionstresstest js advisories" (#25) as a floor, to drag postcss up past an advisory current at the time. Written as an exact version rather than a range, the floor became a ceiling, and it has been holding postcss below every fix published since. Three advisories are open against it, and the pin sat below the earliest of them: - CVE-2026-45623, high, arbitrary file read via attacker-controlled source map (patched 8.5.12) - GHSA-r28c-9q8g-f849, high, path traversal in previous-source-map auto-loading (patched 8.5.18) - CVE-2026-69153, medium (patched 8.5.23) Changing the override to ^8.5.23 clears all three and keeps the original intent, which was to hold postcss above known-vulnerable versions rather than at one specific version. npm resolves this to 8.5.25 and dedupes while it is at it: the three nested copies under @tailwindcss/postcss, next, and vite collapse into a single hoisted postcss, so the package count drops from 613 to 611. The only other version change is nanoid 3.3.12 to 3.3.17, which postcss depends on. Worth recording for whoever triages these next: the advisories describe a service that accepts user-submitted CSS and runs it through PostCSS. Here postcss only runs inside the build toolchain over first-party CSS, so the realistic exposure is a dependency injecting CSS into the build rather than anything reachable by a user of the app. GitHub scores it runtime because postcss sits in a production dependency tree, not because it ships. Verified against a baseline captured at 8.5.10 before the change, with identical results after: typecheck clean, 106 tests across 35 files passing, and next build completing.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes the postcss override from the exact pin
8.5.10to the range^8.5.23, clearing all three open postcss advisories.The pin had become the problem
overrides.postcsswas set to exactly8.5.10, forcing that version into all three consumers that pull postcss in:@tailwindcss/postcss,next, andvite.That pin was added by "fix: patch decisionstresstest js advisories" (#25) as a floor, to drag postcss up past an advisory current at the time. Written as an exact version rather than a range, the floor became a ceiling. It has been holding postcss below every fix published since, including the earliest of the three now open against it:
^8.5.23clears all three and preserves the original intent, which was to hold postcss above known-vulnerable versions rather than at one specific version.Scope
npm resolves this to 8.5.25 and dedupes in the process. The three nested copies under
@tailwindcss/postcss,next, andvitecollapse into a single hoistedpostcss, dropping the package count from 613 to 611. The only other version change isnanoid3.3.12 to 3.3.17, which postcss depends on.Verification
Baseline captured at 8.5.10 before the change, identical after:
npm run typechecknpm testnpm run buildThe ERESOLVE warnings npm prints during install are pre-existing and unrelated:
eslint@^10in the root against plugins fromeslint-config-nextthat declare peers up to^9. They are warnings, not errors, and predate this change.Context for triaging the rest of these
The postcss advisories describe a service that accepts user-submitted CSS and runs it through PostCSS. Here postcss only runs inside the build toolchain over first-party CSS, so the realistic exposure is a dependency injecting CSS into the build, not anything reachable by a user of the app. GitHub scores it runtime because postcss sits in a production dependency tree, not because it ships to the client. Worth patching, not worth treating as an incident.
The same override-as-ceiling pattern exists in
prompt-englab, capped at^8.5.16.