Add identity audit since-window gate#134
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2fc21c3e0d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if identity_since is not None: | ||
| where = " WHERE datetime(created_at) >= datetime(?)" | ||
| params = (_sqlite_datetime(identity_since),) |
There was a problem hiding this comment.
Skip notification_feed when applying identity-since
When --identity-since is used against a notification DB that still contains notification_feed (including a migration DB that also has durable_events), the branch above selects notification_feed and this new created_at filter is never reached. That means stale backlog rows from the untimestamped feed are still audited and can fail the intended post-fix regression gate even though the CLI/README describe the window as applying only to notification-hub durable events. In since-window mode, skip the feed or prefer the durable_events query.
Useful? React with 👍 / 👎.
What
Why
The identity backlog remains noisy, but producer fixes need a current regression gate. This lets us verify new drift after a known producer-fix timestamp without migrating historical rows first.
Verification