Use temporary folder for tests#71
Closed
chris-allan wants to merge 1 commit intosaalfeldlab:masterfrom
Closed
Conversation
c28f8ee to
d122ddc
Compare
Author
|
The original implementation in #70 had the temporary folder rule in the Happy to go with either option. Edit: The original abstract method style could also be restored with something to the effect of: protected abstract N5Writer createN5Writer() throws IOException;
@Before
public void setUp() throws IOException {
n5 = createN5Writer();
} |
Author
|
@axtimwalde: Was this what you were thinking? |
Contributor
|
We have since refactored the N5 Tests, and the AbstractN5Test should be using temporary folders now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slightly refactored version of the temporary folder test changes originally proposed in #70.
Test cases now use a temporary folder and subclasses are responsible for setting up the
n5implementation.