[6.0] fix: Do no sort listeners differently depending on their type - #165
Closed
phil-davis wants to merge 1 commit into
Closed
[6.0] fix: Do no sort listeners differently depending on their type#165phil-davis wants to merge 1 commit into
phil-davis wants to merge 1 commit into
Conversation
With array_multisort, when priority is the same it would fallback to comparing values, and PHP will sort Closures after array callables. This is not something we want as it means turning an array callable into a Closure would potentially change its order, leading to unexpected side-effects. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #165 +/- ##
============================================
+ Coverage 99.18% 99.22% +0.03%
- Complexity 111 119 +8
============================================
Files 7 7
Lines 370 388 +18
============================================
+ Hits 367 385 +18
Misses 3 3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
I mistakenly made this against |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #162 to the 6.0 branch. This will allow a patch release 6.0.3. And that can be picked up by the current
sabre/davrelease series, which is still supporting PHP 7.4.With array_multisort, when priority is the same it would fallback to
comparing values, and PHP will sort Closures after array callables.
This is not something we want as it means turning an array callable into
a Closure would potentially change its order, leading to unexpected
side-effects.