[6.0] fix: Do no sort listeners differently depending on their type - #166
Merged
phil-davis merged 1 commit intoJul 7, 2026
Merged
Conversation
With array_multisort, when priority is the same it would fallback to comparing values, and PHP will sort Closures after array callables. This is not something we want as it means turning an array callable into a Closure would potentially change its order, leading to unexpected side-effects. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #162 to the 6.0 branch. This will allow a patch release 6.0.3. And that can be picked up by the current sabre/dav release series.
With array_multisort, when priority is the same it would fallback to
comparing values, and PHP will sort Closures after array callables.
This is not something we want as it means turning an array callable into
a Closure would potentially change its order, leading to unexpected
side-effects.