Skip to content

refactor: Always use hash_hmac - #290

Merged
phil-davis merged 2 commits into
masterfrom
carl/hash_hmac
Jul 15, 2026
Merged

refactor: Always use hash_hmac#290
phil-davis merged 2 commits into
masterfrom
carl/hash_hmac

Conversation

@CarlSchwan

Copy link
Copy Markdown
Contributor

We now depends on PHP 8.2 where this method is part of the core.

Fix #193

@CarlSchwan
CarlSchwan requested a review from phil-davis July 15, 2026 08:07
@CarlSchwan CarlSchwan self-assigned this Jul 15, 2026
@CarlSchwan
CarlSchwan force-pushed the carl/hash_hmac branch 2 times, most recently from 87e58bb to 9b4c58a Compare July 15, 2026 08:15
@phil-davis

Copy link
Copy Markdown
Contributor

@CarlSchwan I made phpstan pass by removing an unused test method.
But there is still a unit test failing: https://github.com/sabre-io/http/actions/runs/29401328256/job/87306313723?pr=290

There was 1 failure:

1) Sabre\HTTP\Auth\AWSTest::testValidRequest
Signature did not validate, got errorcode 5
Failed asserting that false is true.

/home/runner/work/http/http/tests/HTTP/Auth/AWSTest.php:193

Please have a look.

@CarlSchwan

Copy link
Copy Markdown
Contributor Author

The test failure is definitively related :(

CarlSchwan and others added 2 commits July 15, 2026 10:46
We now depends on PHP 8.2 where this method is part of the core.

Signed-off-by: Carl Schwan <carlschwan@kde.org>
Signed-off-by: Phillip Davis <phil@jankaritech.com>
@CarlSchwan

Copy link
Copy Markdown
Contributor Author

@phil-davis fixed! Good thing that the test coverage in sabre is so high :)

@phil-davis
phil-davis merged commit 13ff16c into master Jul 15, 2026
4 checks passed
@phil-davis
phil-davis deleted the carl/hash_hmac branch July 15, 2026 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lib/AuthAWS.php hmacsha1 does not get test coverage

2 participants