refactor: Always use hash_hmac - #290
Merged
Merged
Conversation
CarlSchwan
force-pushed
the
carl/hash_hmac
branch
2 times, most recently
from
July 15, 2026 08:15
87e58bb to
9b4c58a
Compare
phil-davis
force-pushed
the
carl/hash_hmac
branch
from
July 15, 2026 08:35
aad4004 to
850d92f
Compare
Contributor
|
@CarlSchwan I made Please have a look. |
Contributor
Author
|
The test failure is definitively related :( |
We now depends on PHP 8.2 where this method is part of the core. Signed-off-by: Carl Schwan <carlschwan@kde.org>
Signed-off-by: Phillip Davis <phil@jankaritech.com>
CarlSchwan
force-pushed
the
carl/hash_hmac
branch
from
July 15, 2026 08:46
850d92f to
a02414b
Compare
Contributor
Author
|
@phil-davis fixed! Good thing that the test coverage in sabre is so high :) |
phil-davis
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now depends on PHP 8.2 where this method is part of the core.
Fix #193