Skip to content

feat: Allow to stream input - #338

Open
CarlSchwan wants to merge 3 commits into
masterfrom
carl/reader-stream
Open

feat: Allow to stream input#338
CarlSchwan wants to merge 3 commits into
masterfrom
carl/reader-stream

Conversation

@CarlSchwan

@CarlSchwan CarlSchwan commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Fixes #337

@CarlSchwan CarlSchwan self-assigned this Jul 15, 2026
Comment thread phpstan-rules-lt-8.4.neon Outdated
Comment thread phpstan.conditional.php Outdated
@CarlSchwan
CarlSchwan force-pushed the carl/reader-stream branch 3 times, most recently from fab9f68 to e3f8bb1 Compare July 15, 2026 10:05
@CarlSchwan
CarlSchwan marked this pull request as ready for review July 15, 2026 10:55
@CarlSchwan
CarlSchwan force-pushed the carl/reader-stream branch 2 times, most recently from ae27e12 to 9479368 Compare July 15, 2026 10:59
@CarlSchwan CarlSchwan linked an issue Jul 15, 2026 that may be closed by this pull request
phil-davis
phil-davis previously approved these changes Jul 15, 2026

@phil-davis phil-davis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@staabm staabm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems most of the changes miss test-coverage?

Comment thread phpstan.conditional.php Outdated
Comment thread tests/Sabre/Xml/ServiceTest.php
Signed-off-by: Carl Schwan <carlschwan@kde.org>
New error detected by phpstan with PHP 8.5

Signed-off-by: Carl Schwan <carlschwan@kde.org>
@CarlSchwan
CarlSchwan force-pushed the carl/reader-stream branch from c3b6ece to b7db1db Compare July 15, 2026 12:25
Signed-off-by: Carl Schwan <carlschwan@kde.org>
@CarlSchwan
CarlSchwan force-pushed the carl/reader-stream branch from b7db1db to 87c9110 Compare July 15, 2026 12:31
@phil-davis
phil-davis self-requested a review July 15, 2026 12:36
@phil-davis
phil-davis dismissed their stale review July 15, 2026 12:36

We need to sort out the test coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make use of XMLReader::fromStream

3 participants