fix: fail fast when graphify.serve is launched interactively#312
Draft
lttlin wants to merge 1 commit intosafishamsi:v4from
Draft
fix: fail fast when graphify.serve is launched interactively#312lttlin wants to merge 1 commit intosafishamsi:v4from
lttlin wants to merge 1 commit intosafishamsi:v4from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Running
python -m graphify.serve graphify-out/graph.jsondirectly from an interactive terminal feeds the MCP stdio server an empty TTY stream. That bubbles up as a low-level JSON-RPC parse failure instead of explaining that the command must be launched by an MCP client.Root Cause
graphify.serveimmediately enters the stdio transport loop without checking whether stdin/stdout are attached to an interactive terminal. In that mode the MCP runtime tries to parse non-protocol input and reports an EOF/invalid JSON error.Fix
Add an interactive-stdio guard before starting the MCP server. When stdin or stdout is a TTY,
graphify.servenow prints a clear error and exits early instead of surfacing an internal server exception.Validation
/tmp/graphify_issue_201/.venv/bin/python -m pytest tests/test_serve.pyCloses #201