Strengthen validation workflow#2
Conversation
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2f75bd8d3c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| bash -n scripts/validate-secrets.sh | ||
|
|
||
| - name: Validate secret placeholders | ||
| run: bash scripts/validate-secrets.sh |
There was a problem hiding this comment.
The new Validate secret placeholders step only runs bash scripts/validate-secrets.sh, but that script currently exits successfully even when placeholders are found (its if grep ...; then branch only prints a warning and does not exit 1). In this repository it also matches its own 'replace_with_' literal, so the check reports detections but still passes, meaning PRs are not actually blocked when placeholder secrets exist.
Useful? React with 👍 / 👎.
1 participant
Adds stronger validation coverage for workflow JSON, Docker compose config, shell syntax, and placeholder checks.