fix: textinput handlefocus and styles#125
Merged
loc-nguyenthien merged 5 commits intodevelopfrom Mar 30, 2026
Merged
Conversation
Test Result
Details
|
danhmaisgt
reviewed
Nov 4, 2025
| activeOpacity={1} | ||
| onPress={handleFocus} | ||
| disabled={editable ?? TextInputTheme.editable}> | ||
| disabled={!!editable}> |
Contributor
There was a problem hiding this comment.
I think it should be disabled={!editable}>
Contributor
Author
There was a problem hiding this comment.
Great! You got the point
dfbb2ae to
dc0bafb
Compare
hangnguyensaigontech
approved these changes
Nov 4, 2025
danhmaisgt
reviewed
Nov 4, 2025
Comment on lines
+76
to
+83
| <TouchableOpacity | ||
| style={[demoStyles.controlButton, hasSuccess && demoStyles.controlButtonSecondary]} | ||
| onPress={toggleSuccess} | ||
| > | ||
| <Text style={demoStyles.controlButtonText}> | ||
| {hasSuccess ? 'Remove Success' : 'Add Success'} | ||
| </Text> | ||
| </TouchableOpacity> |
Contributor
There was a problem hiding this comment.
Do we need the this? I see it's just rendering the text
Contributor
Author
There was a problem hiding this comment.
I think it's a useless button as well
dc0bafb to
3ca0f85
Compare
danhmaisgt
approved these changes
Nov 4, 2025
loc-nguyenthien
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Features
Bugs
Check List
Proof of Completeness

OR Video linkTextInputDemo.mp4