Fixed issue with Moment.js Date formatting#40
Open
jimallen wants to merge 1 commit intosailrish:masterfrom
Open
Fixed issue with Moment.js Date formatting#40jimallen wants to merge 1 commit intosailrish:masterfrom
jimallen wants to merge 1 commit intosailrish:masterfrom
Conversation
Owner
|
Hi @jimallen thanks for the PR. Just curious, how is this: different from: I do realize I have a deprecation warning related to moment.js, that I still have to fix: |
Owner
|
Also, can you please paste the DHL test failure you're seeing? I don't see one locally, but that may be because of timezone related issues. |
|
@sailrish The moment.js depreciation warning is still present-- does this PR have any issues that need to be addressed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DHL test seem broken, I didn't touch it :)