updated http to accept any content header that includes xml - #1
Open
edencorbin wants to merge 2 commits into
Open
updated http to accept any content header that includes xml#1edencorbin wants to merge 2 commits into
edencorbin wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firstly thanks for the helpful repo, it works well. In the case I was working with I had to change the original: req.headers['content-type'] == 'application/xml' as what was sent from recurly (a billing service) was 'application/xml; charset=utf-8', to make this generic I'm recommending updating it to: var cType =req.headers['content-type']; if (cType.indexOf('xml')>-1) { which seems to work well from some quick testing. Cheers.