Skip to content

[proposal] make req actually emit warnings per documented behavior #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thesaxonedone wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[proposal] make req actually emit warnings per documented behavior #191

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
87498fb
make req actually emit warnings per documented behavior
thesaxonedone Jun 17, 2019
37682d8
fixed a miss
thesaxonedone Jun 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions lib/private/multipart.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,19 +43,18 @@ module.exports = function toParseMultipartHTTPRequest(options) {
// If parser emits `warning`, also emit it on `req` so it can be captured
// by your app. When NODE_ENV != 'production', if `req._sails` exists, this
// will attempt to log a message to the console using your configured logger.
// If this doesn't work, it logs a message. In production, no warnings are emitted.
if (process.env.NODE_ENV !== 'production') {
parser.on('warning', function(msg) {
// If this doesn't work, it logs a message.
parser.on('warning', function(msg) {
req.emit('warning', msg);
if (process.env.NODE_ENV !== 'production') {
if (req._sails) {
try {
req._sails.log.verbose(msg);
} catch (unusedErr) {}
} else {
debug(msg);
}
});//œ
}//fi

}//fi
});//œ
};
};