EVALSYS-1445 Handle null instructor view-all results - #186
Open
ottenhoff wants to merge 3 commits into
Open
Conversation
ottenhoff
marked this pull request as ready for review
July 10, 2026 15:59
ottenhoff
changed the title
Contributor
|
Thanks, Sam. Looks correct to me, but one spot with the same unboxing bug doesn't seem to be covered by this PR: ControlEvaluationsController.java:399 if ((eval.getInstructorViewResults() && This has the identical pattern you just fixed in ReportingPermissionsImpl.java (direct unboxing inside an ||), so it would NPE on the same legacy null values. Might be worth including it here for consistency. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Treat null
EvalEvaluation.instructorViewAllResultsvalues as false in report export and reporting permission paths.This prevents legacy rows with
EVAL_EVALUATION.INSTRUCTOR_VIEW_ALL_RESULTS = NULLfrom throwing when PDF reports, individual PDF reports, CSV/XLS report paths, or related reporting permission logic unbox the nullable Boolean.Root cause
The database column and Hibernate mapping allow null, but several consumers directly unboxed
getInstructorViewAllResults(). Existing defaults cover many newly saved evaluations, but legacy null values can still reach report generation.Validation
mvn -pl sakai-evaluation-impl,sakai-evaluation-tool -am -DskipTests compile