-
Notifications
You must be signed in to change notification settings - Fork 1
feat: add invoke() to DederProjectInternals for dynamic task invocati… #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
e3762d4
feat: add invoke() to DederProjectInternals for dynamic task invocati…
sake92 ecd5b53
feat: add TaskInvokerApi with notification callback and plaintext res…
sake92 23f36b3
cleanup: remove redundant invokeInternal, delegate simple invoke dire…
sake92 0e8b507
cleanup: remove duplicate invoke from DederProjectInternals trait, ke…
sake92 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Silent failure when module resolution fails.
When
readStatereturnsLeft(parse/load error) orWildcardUtils.getMatchesOrRecommendationsreturnsLeft(no matches),resolvedIdsbecomesSeq.empty. This silently produces an emptyTaskInvokeResultwith no indication to the plugin caller that module resolution failed.Consider propagating the error or returning a distinguished failure outcome so plugins can diagnose misconfigurations.
Possible approach
val resolvedIds = state.readState(useLastGood = false) match { - case Left(_) => Seq.empty + case Left(err) => + return TaskInvokeResult(Seq.empty, Some(s"Failed to read project state: $err")) case Right(s) => val allIds = s.tasksResolver.allModules.map(_.id) if moduleIds.isEmpty then allIds else WildcardUtils.getMatchesOrRecommendations(allIds, moduleIds) match { - case Left(_) => Seq.empty + case Left(suggestions) => + val hint = if suggestions.nonEmpty then s" Did you mean: ${suggestions.mkString(", ")}?" else "" + return TaskInvokeResult(Seq.empty, Some(s"No modules matched: ${moduleIds.mkString(", ")}.$hint")) case Right(ids) => ids } }🤖 Prompt for AI Agents