specify argparse port argument as int - #6
Open
drewbell wants to merge 1 commit into
Open
Conversation
background: the constructor of the Saleae class requires that the port argument being provided is an integer, otherwise the construction fails and crashes the program. By default, argparse parses arguments as strings, so previously specifying a port via the CLI would crash the program. Specifying the port argument as an int in add_argument() solves this problem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
background: the constructor of the Saleae class requires that the port
argument being provided is an integer, otherwise the construction fails
and crashes the program. By default, argparse parses arguments as
strings, so previously specifying a port via the CLI would crash the
program. Specifying the port argument as an int in add_argument() solves
this problem.