Add chip select support - #14
Draft
tannewt wants to merge 1 commit into
Draft
Conversation
Clocks outside chip select low will be ignored. Data captured will include an "index" key with the clock count from the assertion of chip select. Data frames now span between inactive edges. (Saleae's start on the active edge.) This better mirrors diagrams where data changes around inactive edges. Polarity is also detected at CS assertion and a rising CS edge can be the final inactive edge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opened as a draft to see if you'd want to integrate this functionality into the shipped version. We'd need to do a couple things before it is backwards compatible:
Clocks outside chip select low will be ignored. Data captured will include an "index" key with the clock count from the assertion of chip select.
Data frames now span between inactive edges. (Saleae's start on the active edge.) This better mirrors diagrams where data changes around inactive edges. Polarity is also detected at CS assertion and a rising CS edge can be the final inactive edge.