[master] AWS SESSION TOKEN returned - #64639
Open
Tanmoy037 wants to merge 1 commit into
Open
Conversation
salt-project-bot-prod-environment
Bot
changed the title
Ch3LL
previously requested changes
Aug 2, 2023
Ch3LL
left a comment
Ch3LL
left a comment
Contributor
There was a problem hiding this comment.
Changelog looks good, this just needs test coverage now.
Contributor
|
@Tanmoy037 Can you rebase this and resolve the conflicts? Ideally, add a test too. |
twangboy
requested changes
Apr 11, 2025
twangboy
left a comment
twangboy
left a comment
Contributor
There was a problem hiding this comment.
Please create a test for this
twangboy
added
needs-testcase
When a ``token`` key is present in the EC2 provider configuration, forward it as the security token in AWS API calls. Previously only the ``id`` and ``key`` were used for static credentials. Fixes saltstack#64533
twangboy
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes salt-cloud using ec2 authenticate fails
What issues does this PR fix or reference?
Fixes: #64533
Previous Behavior
Remove this section if not relevant
New Behavior
Remove this section if not relevant
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes/No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.