Fix log of dead processes in reap_stray_processes#68928
Open
m-czernek wants to merge 1 commit intosaltstack:masterfrom
Open
Fix log of dead processes in reap_stray_processes#68928m-czernek wants to merge 1 commit intosaltstack:masterfrom
m-czernek wants to merge 1 commit intosaltstack:masterfrom
Conversation
If reap_stray_processes cannot kill a process, it logs which process it gived up on. However, if the process exits after the alive check and before the log, this causes psutil.NoSuchProcess exception
m-czernek
added a commit
to openSUSE/salt
that referenced
this pull request
Apr 14, 2026
* Fix test failures salt/states/pkgrepo.py: - saltstack/salt@919994f tests/pytests/functional/modules/test_pkg.py: - saltstack/salt@7835f3a - saltstack/salt@6dc6cc3 tests/integration/modules/test_gem.py: - Started failing because after several years, brass released a new version - saltstack/salt@1d4f9dc tests/pytests/unit/modules/test_aptpkg.py: - Was broken after our latest code upgrade * Fix reap_stray_processes fixture error - saltstack/salt#68928
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If reap_stray_processes cannot kill a process,
it logs which process it gived up on. However,
if the process exits after the alive check and
before the log, this causes psutil.NoSuchProcess
exception
Commits signed with GPG?
Yes/No