add FilterRejectUnstable implementations - #904
Open
hizani wants to merge 1 commit into
Open
Conversation
Author
|
In defense of this solution I can say that in my tasks it often doesn’t matter in what order the function returns the results. I believe there are as many cases where order doesn't matter as there are cases that require stable implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new
FilterRejectUnstablefunction to both themutableandlopackages. Benchmarks show that the mutable implementation is 7–10x faster than the originallo.FilterRejecton my machine.I understand that introducing an unstable version is a controversial choice, but I couldn’t come up with a similarly efficient stable implementation (at least not as clean as this one). The performance gain justifies this approach for me.
I first implemented only an in‑place version in the
mutablepackage but then I realized that this approach could also be useful in thelopackage. Although its speed is not much faster than the originalFilterReject, it cuts memory usage in half compared to the original implementation, which makes it especially helpful for large collections.