Conversation
- Add go-version-file: go.mod to all setup-go steps (govulncheck, codeql, trivy-codeql, trivy-logs) - Add .trivyignore for 5 CVEs in recovery/gin transitive deps (x/crypto, x/net via gin v1.9.1); Dependabot handles upgrades - Add trivyignores: .trivyignore to both trivy jobs - Run go mod tidy across all sub-modules (examples, loggers, benchmarks, recovery/gin)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #112 +/- ##
=======================================
Coverage 88.74% 88.74%
=======================================
Files 15 15
Lines 1155 1155
=======================================
Hits 1025 1025
Misses 103 103
Partials 27 27
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR addresses CI security-scan failures by aligning GitHub Actions’ Go toolchain selection with the repo’s declared Go version, configuring Trivy to honor an ignore list, and tidying Go module metadata across submodules.
Changes:
- Pin
actions/setup-goto usego-version-file: go.modin security scan workflows. - Add
.trivyignoreand wire it into Trivy scan jobs to suppress known transitive CVEs. - Run
go mod tidyacross multiple submodules, updatinggo.mod/go.sumaccordingly.
Reviewed changes
Copilot reviewed 14 out of 25 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/security.yml | Uses go-version-file for setup-go; passes .trivyignore to Trivy jobs. |
| .trivyignore | Adds Trivy ignore entries for specific CVEs in transitive deps. |
| benchmarks/go.mod | Tidies module requirements (promotes lo to direct). |
| examples/log/go.mod | Tidies deps; now pins github.com/samber/oops version. |
| examples/log/go.sum | Updates sums after go mod tidy. |
| examples/logrus/go.mod | Tidies deps; adds explicit requirements including logger module pseudo-version. |
| examples/logrus/go.sum | Updates sums after go mod tidy. |
| examples/panic/go.mod | Tidies deps; adds explicit requirements including logger module pseudo-version. |
| examples/panic/go.sum | Updates sums after go mod tidy. |
| examples/segfault/go.mod | Tidies deps; adds explicit requirements including logger module pseudo-version. |
| examples/segfault/go.sum | Updates sums after go mod tidy. |
| examples/slog/go.mod | Tidies deps; now pins github.com/samber/oops version. |
| examples/slog/go.sum | Updates sums after go mod tidy. |
| examples/sources/go.mod | Tidies deps; now pins github.com/samber/oops version. |
| examples/sources/go.sum | Updates sums after go mod tidy. |
| examples/zap/go.mod | Tidies indirect versions. |
| examples/zap/go.sum | Updates sums after go mod tidy. |
| examples/zerolog/go.mod | Tidies indirect versions. |
| examples/zerolog/go.sum | Updates sums after go mod tidy. |
| loggers/logrus/go.mod | Promotes go.uber.org/goleak to a direct requirement post-tidy. |
| loggers/logrus/go.sum | Updates sums after go mod tidy. |
| loggers/zap/go.mod | Promotes go.uber.org/goleak to a direct requirement post-tidy. |
| loggers/zap/go.sum | Updates sums after go mod tidy. |
| loggers/zerolog/go.mod | Promotes go.uber.org/goleak to a direct requirement post-tidy. |
| loggers/zerolog/go.sum | Updates sums after go mod tidy. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
go-version-file: go.modto allactions/setup-gosteps (govulncheck, codeql, trivy-codeql, trivy-logs) to pin Go to the declared minimum and silence the version warning.trivyignoresuppressing 5 CVEs inrecovery/gintransitive deps (golang.org/x/crypto+golang.org/x/netvia gin v1.9.1) — Dependabot will handle bumps when a go 1.21-compatible fix is availabletrivyignores: .trivyignoreinto both trivy scan jobs so the ignore file is respectedgo mod tidyacross all sub-modules (examples, loggers, benchmarks, recovery/gin) to clean up stale go.sum files flagged by CodeQL autobuildFixes
govulncheck— still reports stdlib vulns (require Go 1.25 to fix) but CI now runs on the correct Go versiontrivy-logs— 5 CVEs in recovery/gin suppressed via.trivyignore; job should pass