Replace TRUE/FALSE with IS_TRUE/IS_FALSE on macros#1
Open
pafuent wants to merge 1 commit intosamcragg:masterfrom
Open
Replace TRUE/FALSE with IS_TRUE/IS_FALSE on macros#1pafuent wants to merge 1 commit intosamcragg:masterfrom
TRUE/FALSE with IS_TRUE/IS_FALSE on macros#1pafuent wants to merge 1 commit intosamcragg:masterfrom
Conversation
This fix projects/compilers that has defined `TRUE` as a macro. As an example, using cpp_mock with mingw will result on mocked method names not being identified as defined types when the number of parameters where one or zero. That was caused because `DEFINE_EXISTS` macro used `TRUE` wich was expanded to `1`, and that being concatenated to `MOCK_METHOD_SINGLE_`. Because `MOCK_METHOD_SINGLE_1` was not defined as a macro the preprocesed code was invalid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix projects/compilers that has defined
TRUEas a macro. As an example, using cpp_mock with mingw will result on mocked method names not being identified as defined types when the number of parameters where one or zero.That was caused because
DEFINE_EXISTSmacro usedTRUEwhich was expanded to1, and that being concatenated toMOCK_METHOD_SINGLE_. BecauseMOCK_METHOD_SINGLE_1was not defined as a macro the preprocessed code was invalid.If you compile this with
mingwyou can reproduce the issue: