Skip to content

perf(android): optimize seekbar sync and filter out trivial media progress updates #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sameerasw merged 1 commit into from
Jun 4, 2026
+15 −2
Merged

perf(android): optimize seekbar sync and filter out trivial media progress updates #115

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions app/src/main/java/com/sameerasw/airsync/service/MediaNotificationListener.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,19 @@ class MediaNotificationListener : NotificationListenerService() {
SyncManager.checkAndSyncDeviceStatus(context, forceSync = true)
}

fun hasSignificantMediaChange(old: MediaInfo?, new: MediaInfo?): Boolean {
if (old == null && new == null) return false
if (old == null || new == null) return true
return old.isPlaying != new.isPlaying ||
old.title != new.title ||
old.artist != new.artist ||
old.albumArt != new.albumArt ||
old.albumArtLite != new.albumArtLite ||
old.durationMs != new.durationMs ||
old.isBuffering != new.isBuffering ||
old.likeStatus != new.likeStatus
}

// In-memory cache of like status per track key
private val likeStatusCache = LinkedHashMap<String, String>(32, 0.75f, true)

Expand Down Expand Up @@ -472,7 +485,7 @@ class MediaNotificationListener : NotificationListenerService() {
updateMediaInfo()

// If media info changed, trigger sync
if (previousMediaInfo != currentMediaInfo) {
if (hasSignificantMediaChange(previousMediaInfo, currentMediaInfo)) {
Log.d(TAG, "Media info changed, triggering sync")
SyncManager.onMediaStateChanged(this)
}
Expand Down Expand Up @@ -527,7 +540,7 @@ class MediaNotificationListener : NotificationListenerService() {
updateMediaInfo()

// If media info changed, trigger sync
if (previousMediaInfo != currentMediaInfo) {
if (hasSignificantMediaChange(previousMediaInfo, currentMediaInfo)) {
Log.d(TAG, "Media info changed after notification removal, triggering sync")
SyncManager.onMediaStateChanged(this)
}
Expand Down