fix: flush pending drop cleanup to prevent fast-drag races#54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Description
Related Issue
Closes #
Changes
What
Fixes state corruption when a drop's deferred cleanup (the ~200ms drop-snap animation timeout) overlaps with a new drag or a cancel.
Why
dragEndschedulesfinalizeDropon asetTimeout(DROP_SNAP_MS). Until it ran, a fast second drag or adragCancelcould race it — the previous row stayed hidden or its late cleanup clobbered the new drag.Changes
pendingFinalizeRef,dropAnimTimeoutRef).flushPendingDrop()clears the timeout and runs the finalize synchronously.flushPendingDrop()at the top ofbeginDrag(beforedragEndFiredRefresets) and indragCancel.requestAnimationFrameifdragEndFiredRefis already set.Testing
npm run lint+npm run buildpass (CI gates this).Screenshots / Demos
Checklist
npm run format)npm run lintwith no errorsCHANGELOG.mdif applicable