Skip to content

feat: add Homebrew cask definition and automated generation script#16

Open
samirpatil2000 wants to merge 1 commit into
mainfrom
feature/homebrew-setup
Open

feat: add Homebrew cask definition and automated generation script#16
samirpatil2000 wants to merge 1 commit into
mainfrom
feature/homebrew-setup

Conversation

@samirpatil2000

Copy link
Copy Markdown
Owner

No description provided.

@samirpatil2000 samirpatil2000 self-assigned this Apr 11, 2026
@chatgpt-codex-connector

Copy link
Copy Markdown

💡 Codex Review

if event.modifierFlags.contains(.command) {
onDelete()
return nil

P1 Badge Exclude text-edit shortcuts from destructive delete handler

GlobalKeyMonitor deletes the selected history item on any ⌘⌫ keypress without checking whether the user is currently editing text. Because the search field is focused when the window opens, a normal macOS text-edit action like ⌘⌫ (clear to beginning of line) will unexpectedly delete clipboard history entries, which is destructive and easy to trigger accidentally.


if let filename = store.saveText(text) {
let item = ClipboardItem.largeText(preview: preview, filename: filename, sourceApp: sourceApp)
store.add(item)
print("[Buffer] Large text (\(textSize / 1024) KB) saved to file: \(filename)")
}

P2 Badge Add fallback when large text cannot be saved to disk

For large text payloads, the watcher only adds an item when saveText succeeds; if file persistence fails (e.g., disk full, permission issues), the clipboard change is silently dropped and never appears in history. This creates data loss specifically for large entries and regresses reliability versus the small-text path, so it should fall back to inline/truncated storage instead of doing nothing.


let hashSource = textSize > inlineTextLimit ? String(text.prefix(10_000)) : text
let hash = hashSource.hashValue

P2 Badge Avoid prefix-only hash for large-text deduplication

Deduplication hashes only the first 10,000 characters for large text, so two different large clipboard entries that share that prefix are treated as duplicates and the newer one is dropped. This is realistic for long logs/JSON blobs with common headers and causes missed captures; dedupe should incorporate the full content (or a stronger digest strategy that still distinguishes differing tails).

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant