Skip to content

feat: App filter popover, source metadata & copied app source icon#25

Open
andonits wants to merge 2 commits into
samirpatil2000:mainfrom
andonits:feature/app-filter-popover-source-metadata
Open

feat: App filter popover, source metadata & copied app source icon#25
andonits wants to merge 2 commits into
samirpatil2000:mainfrom
andonits:feature/app-filter-popover-source-metadata

Conversation

@andonits

@andonits andonits commented May 15, 2026

Copy link
Copy Markdown

Summary

  • Replaces the compact app filter UI with a popover: a master “All apps” switch plus per-app toggles on a narrow, scrollable panel (AppFilterPopover.swift).
  • Captures and persists richer copy source context (SourceContext on ClipboardItem, SourceResolver, ClipboardWatcher) so list rows can show app vs browser badges where available.
  • Adds AppIconCache for sharper, safe icon reuse in list and filter rows (ClipboardItemRow updates).
  • Fixes “All apps” off behavior by using an optional whitelist (Set<String>?) so the UI no longer snaps back when everything is disabled.
  • Updates .gitignore to exclude .idea/ and copy_source_label_plan.md so local IDE and planning files are not committed.

Demo

Screen.Recording.2026-05-15.at.12.09.20.mov

Test plan

  • History window → open filter popover: layout, scrolling, row hover, toggles behave as expected.
  • Toggle All apps off → empty list until at least one app is enabled; toggle All apps on → full history returns.
  • Per-app toggles → list only shows items from allowed sources; unknown/missing source handling still makes sense.
  • Copy from a few apps (and a supported browser if applicable) → new items show appropriate source badges/icons.
  • xcodebuild/Run in Xcode (macOS) succeeds.

andonits and others added 2 commits May 15, 2026 12:11
Wire source resolution and icon caching for list/popover badges, broaden
clipboard capture where possible, and keep JetBrains IDEA files and local
planning docs out of the repo via .gitignore.

Co-authored-by: Cursor <cursoragent@cursor.com>
@andonits

andonits commented May 15, 2026

Copy link
Copy Markdown
Author

@samirpatil2000 Made a small improvement where you can see the app or browser of the copied text / image. Included a filter lets you filter by specific apps as well. Will appreciate you feedback and review

@andonits andonits changed the title App filter popover, source metadata & icon cache feat: App filter popover, source metadata & icon cache May 15, 2026
@andonits andonits changed the title feat: App filter popover, source metadata & icon cache feat: App filter popover, source metadata & copied app source icon May 15, 2026
@samirpatil2000

Copy link
Copy Markdown
Owner

Hey @andonits, thanks so much for taking the time to contribute and for putting so much thought into this – really appreciate it.

I like the core idea a lot, but it feels a bit more developer‑focused than where I want to take Buffer right now. My aim is to keep the app simpler and a bit more general‑purpose, rather than leaning too much into power‑user/dev tooling.

I had a similar idea earlier and ended up shipping a new feature that lets you search/filter based on tags instead. You can check it out here: https://github.com/samirpatil2000/Buffer/releases/tag/buffer-v2.0.0

Thanks again for the PR and for helping improve the project – your contributions and ideas really add value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants