Skip to content

fix(export): replace JSONL targets atomically - #135

Merged
samzong merged 3 commits into
mainfrom
feature/release-0.5-ng08
Aug 14, 2026
Merged

fix(export): replace JSONL targets atomically#135
samzong merged 3 commits into
mainfrom
feature/release-0.5-ng08

Conversation

@samzong

@samzong samzong commented Aug 14, 2026

Copy link
Copy Markdown
Owner

Summary

  • write session JSONL exports to a same-directory temporary file
  • sync and atomically replace the output only after export succeeds
  • preserve an existing target and remove temporary output when export fails

Closes release blocker NG-08.

Verification

  • cargo test session::tests::jsonl_file_export_replaces_target_only_after_success -- --exact
  • make check

Signed-off-by: samzong <samzong.lu@gmail.com>
@samzong

samzong commented Aug 14, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0a90891c04

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/session.rs Outdated
Signed-off-by: samzong <samzong.lu@gmail.com>
@samzong

samzong commented Aug 14, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 391f7dff0f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/session.rs
Signed-off-by: samzong <samzong.lu@gmail.com>
@samzong

samzong commented Aug 14, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ea6f901d84

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/session.rs
@samzong
samzong merged commit 6c47077 into main Aug 14, 2026
3 checks passed
@samzong
samzong deleted the feature/release-0.5-ng08 branch August 14, 2026 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant