Skip to content

fix(share): prevent deploying unmanaged directory contents - #136

Merged
samzong merged 3 commits into
mainfrom
feature/release-0.5-ng09
Aug 14, 2026
Merged

fix(share): prevent deploying unmanaged directory contents#136
samzong merged 3 commits into
mainfrom
feature/release-0.5-ng09

Conversation

@samzong

@samzong samzong commented Aug 14, 2026

Copy link
Copy Markdown
Owner

Summary

  • mark empty share directories as Recall-managed
  • validate every directory entry before each Pages deploy
  • migrate only directories whose existing files match released Recall share assets
  • reject canary files added both before and after ownership is established

Verification

  • cargo test publish_dir_rejects_unmanaged_files --lib
  • make check

Signed-off-by: samzong <samzong.lu@gmail.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 53ed4a89ac

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/share/publish.rs Outdated
Signed-off-by: samzong <samzong.lu@gmail.com>
@samzong

samzong commented Aug 14, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 021e77411b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/share/publish.rs Outdated
Signed-off-by: samzong <samzong.lu@gmail.com>
@samzong

samzong commented Aug 14, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🎉

Reviewed commit: 5beff0741e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@samzong
samzong merged commit 2fa05f0 into main Aug 14, 2026
3 checks passed
@samzong
samzong deleted the feature/release-0.5-ng09 branch August 14, 2026 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant