Skip to content

fix(cli): reject invalid time filters - #137

Merged
samzong merged 1 commit into
mainfrom
feature/release-0.5-ng10
Aug 14, 2026
Merged

fix(cli): reject invalid time filters#137
samzong merged 1 commit into
mainfrom
feature/release-0.5-ng10

Conversation

@samzong

@samzong samzong commented Aug 14, 2026

Copy link
Copy Markdown
Owner

Summary

  • reject unsupported explicit time filters across search, session list, usage, and export
  • preserve the default all range, documented aliases, case-insensitive parsing, and raw JSON filter values
  • make the shared time parser fail closed for non-CLI callers

Verification

  • cargo test cli::tests::time_filter_validates_values_for_every_command -- --exact
  • black-box probes: all four commands exit 2 for --time definitely-invalid
  • make check

Signed-off-by: samzong <samzong.lu@gmail.com>
@samzong

samzong commented Aug 14, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: 421885219c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@samzong
samzong merged commit c1b529c into main Aug 14, 2026
3 checks passed
@samzong
samzong deleted the feature/release-0.5-ng10 branch August 14, 2026 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant