Skip to content

Y26-005 - LCM Triomics - assign Project / Cost Code to automated submissions#2732

Open
KatyTaylor wants to merge 10 commits intoTriomic_Epicfrom
Y26-005-LCM-Triomics-assign-Project-Cost-Code
Open

Y26-005 - LCM Triomics - assign Project / Cost Code to automated submissions#2732
KatyTaylor wants to merge 10 commits intoTriomic_Epicfrom
Y26-005-LCM-Triomics-assign-Project-Cost-Code

Conversation

@KatyTaylor
Copy link
Copy Markdown
Collaborator

@KatyTaylor KatyTaylor commented Mar 5, 2026

Closes #

Changes proposed in this pull request

  • Quite functional code made by Github Copilot. Adds a field to the choose workflow component, which allows you to search by project id. Adds project uuid to the payload sent to Sequencescape to create the submission - this part doesn't work yet. To add - only display this field when configured to do so. Take hardcoded project out of submission template. Improve styling / UX.
  • (Update: works now)

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

…ose workflow component, which allows you to search by project id. Adds project uuid to the payload sent to Sequencescape to create the submission - this part doesn't work yet. To add - only display this field when configured to do so. Take hardcoded project out of submission template. Improve styling / UX.
@KatyTaylor KatyTaylor linked an issue Mar 5, 2026 that may be closed by this pull request
3 tasks
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 5, 2026

Codecov Report

❌ Patch coverage is 18.75000% with 39 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.81%. Comparing base (d844c3e) to head (3671146).
⚠️ Report is 46 commits behind head on Triomic_Epic.

Files with missing lines Patch % Lines
app/frontend/entrypoints/pages/choose_workflow.js 0.00% 39 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           Triomic_Epic    #2732      +/-   ##
================================================
- Coverage         84.94%   84.81%   -0.14%     
================================================
  Files               503      503              
  Lines             20630    20707      +77     
  Branches            377      377              
================================================
+ Hits              17525    17563      +38     
- Misses             3102     3141      +39     
  Partials              3        3              
Flag Coverage Δ
javascript 80.01% <0.00%> (-0.25%) ⬇️
pull_request 84.79% <18.75%> (-0.16%) ⬇️
push 84.79% <18.75%> (-0.16%) ⬇️
ruby 92.58% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wendyyang wendyyang marked this pull request as ready for review March 31, 2026 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Y26-005 - LCM Triomics - assign Project / Cost Code to automated submissions

2 participants