Skip to content

[ux] Update sample accessioning message #5633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
StephenHulme wants to merge 7 commits into
base: develop
Choose a base branch
from
+48 −24
Open

[ux] Update sample accessioning message #5633

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1f19808
fix: improve readbility of study specification page
StephenHulme Mar 20, 2026
42146c1
feat: add study accessioning checklist to properties page
StephenHulme Mar 20, 2026
ed8aa6e
fix: update links on properties page
StephenHulme Mar 20, 2026
0766650
fix: update sample message with link to checklist
StephenHulme Mar 20, 2026
9b1b1d8
style: lint
StephenHulme Mar 20, 2026
6380142
fix: remove extranous link to study
StephenHulme Mar 31, 2026
3dd7366
Merge branch 'develop' into sh51/update-sample-accessioning-message
StephenHulme Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions app/frontend/stylesheets/all/sequencescape.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -823,6 +823,15 @@ td.qc_pass {
background-color: #ff8;
}

#template_form_body table {
@extend .mb-2;
}

#template_form_body td {
vertical-align: top;
line-height: 1.1em;
}

#plate td.selected {
background-color: #72cf3f;
}
Expand Down
8 changes: 7 additions & 1 deletion app/helpers/samples_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,9 @@ def should_be_accessioned_warning(sample)
def no_accessionable_studies_warning(sample)
accession_warning(
'Sample cannot be accessioned:',
sample.studies.map { |study| "Study '#{link(study)}' is missing an accession number" }
sample.studies.map do |study| # Add list item for each study
"Study '#{link(study)}' is not accessionable - #{accessioning_checklist_link(study)}"
end
)
end

Expand Down Expand Up @@ -65,4 +67,8 @@ def accession_warning(message, items)
def link(study)
link_to(ERB::Util.html_escape(study.name), study_path(study))
end

def accessioning_checklist_link(study)
link_to 'view accessioning checklist', properties_study_path(study, anchor: 'study-accessioning-checklist')
end
end
55 changes: 32 additions & 23 deletions app/views/studies/properties.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,31 +4,40 @@
<% if can? :edit, @study %>
<% add :menu, "Edit" => edit_study_path(@study) -%>
<% end %>
<% if can? :administer, @study %>
<% add :menu, "Manage" => url_for(controller: "admin/studies", action: "show", id: @study.id) -%>
<% end %>
<% add :back_menu, I18n.t("navigation.menu.back_to_study") => study_path(@study) -%>

<div id="content-links">
<%= link_to "View status", study_path(@study) %>
</div>

<div class="page-header"><h1>Study Specification</h1></div>
<div class="card my-4">
<div class="card-body p-3">
<h1 class="text-center">Study Specification</h1>

<table width='100%' cellspacing='0' cellpadding='0'>
<tbody>
<tr>
<td class="item" width="40%">Name:</td>
<td><strong><%=h @study.name %></strong></td>
</tr>
<tr>
<td class="item">Created at:</td>
<td><strong><%=h @study.created_at.to_formatted_s(:day_full_with_time) %></strong></td>
</tr>
<tr>
<td class="item">Study reference genome:</td>
<td><strong><%= @study.study_metadata.reference_genome&.name %></strong></td>
</tr>
</tbody>
</table>
<div id="template_form_body">
<table width='100%' cellspacing='0' cellpadding='0'>
<tbody>
<tr>
<td class="item" width="40%">Name:</td>
<td><strong><%=h @study.name %></strong></td>
</tr>
<tr>
<td class="item">Created at:</td>
<td><strong><%=h @study.created_at.to_formatted_s(:day_full_with_time) %></strong></td>
</tr>
<tr>
<td class="item">Study reference genome:</td>
<td><strong><%= @study.study_metadata.reference_genome&.name %></strong></td>
</tr>
</tbody>
</table>
<%= render partial: 'shared/metadata/show/study', locals: { study: @study } %>
</div>
</div>
</div>

<div id="template_form_body">
<%= render partial: 'shared/metadata/show/study', locals: { study: @study } %>
<div class="card my-4" id="study-accessioning-checklist">
<div class="card-header">Study Accessioning Checklist</div>
<div class="card-body p-4">
<%= render partial: 'studies/information/study_accession_checklist' %>
</div>
</div>
Loading