Conversation
sann05
requested changes
Sep 1, 2022
Owner
sann05
left a comment
sann05
left a comment
There was a problem hiding this comment.
И еще добавь плс проверки для интервалов
sann05
reviewed
Sep 2, 2022
sann05
requested changes
Sep 5, 2022
Owner
sann05
left a comment
sann05
left a comment
There was a problem hiding this comment.
А где тесты на start_time и end_time?
| minutes): | ||
| klines = client.get_klines(symbol='ETH/USD_LEVERAGE', | ||
| interval=interval) | ||
| assert all(val[0] % 60000 == 0 for val in klines) |
Author
There was a problem hiding this comment.
ну тут мы проверяем что первая свеча начинается четко с минуты 00, и вторая что разница(interval) между ними то количество минут которое указывали. И что-то еще?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add test_klines.py