Bug fixes - a header dependency and the sasjsconfig global macroFolders includes all platforms#408
Merged
Bug fixes - a header dependency and the sasjsconfig global macroFolders includes all platforms#408
Conversation
allanbowe
approved these changes
Nov 27, 2025
|
🎉 This PR is included in version 4.59.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
mp_stripdiffs.sasdoes not find themp_ds2squeeze.sasmacro dependency because it is not listed in the correct section.The compile of test programs that utilise cross-platform macros fail due to
sasjsconfig.jsonmacroFoldersettings that limit the visibility of the dependent macros for individual server-types.Intent
Correct the placement of the mp_stripdiffs.sas dependency within the header.
Make all platform macros available to the
sasjscompilation stage.Implementation
Relocated the
@li mp_ds2squeeze.sasdependency to the correct header section inmp_stripdiffs.sas.sasjsconfig.json- the globalmacroFolders[ ]array now includes all platforms so that x-platform testing macros will successfully compile.Checks
sasjs lint).sasjs test).