Refactoring of RectangularMesh and Config Loading#29
Open
keiwanjamaly wants to merge 5 commits intomainfrom
Open
Refactoring of RectangularMesh and Config Loading#29keiwanjamaly wants to merge 5 commits intomainfrom
keiwanjamaly wants to merge 5 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first contribution to simplify the configuration creation as commented by me in #5 (comment).
Here, the config of the mesh generation is outsourced into a config class, such that that class loads, parses the json file and sets defaults. This should simplify test creation in the future drastically, since only the configuration needs to be loaded, which is responsible for testing the subroutine of that code.
By that, also only part of the json file needs to be generated, since most of the parameters can be filled with defaults, which work in most of the cases. Defaults are also localized, making it easier to find and change.
Additionally moved the compilation of DiFfRG out of ExternalProject_Add in the cmake configuration, since this hinders incremental builds and therefore increases compile time.