Open
Conversation
…ivate into feature/Kurganov_Tadmor
…break anything by this
…on and update tests
…boundary ghost cell generation and derivative computations
…ivate into feature/Kurganov_Tadmor
…anov Tadmor scheme
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upon this pull request, the Kurganov Tadmor scheme (a Finite Volume scheme) should be implemented into DiFfRG.
Road to implicit_euler
get_mass_matrixis implemented correctlyget_sparsity_pattern_jacobian(currentlybuild_sparsityis commented out)masshelper functionbuild_sparsityhelper function (hopefully it is correct)jacobian_masshelper functionjacobianhelper functionRoad to sundials_IDA
reinit_vectoris correctly implementedget_differential_indices(currently returns empty set)residual_variables(this would require an update ofbuild_sparsity)jacobian_variables