Cleanup for ref used for react-window#166
Merged
buxomant merged 2 commits intosaucelabs:mainfrom Jul 14, 2025
Merged
Conversation
sakhisheikh
changed the title
buxomant
approved these changes
Jul 14, 2025
Contributor
buxomant
left a comment
buxomant
left a comment
There was a problem hiding this comment.
Looks good, thanks for simplifying the code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We are using _outref (privtate/internal) ref from
react-widow. Instead the API already exposesouterRefas prop toFixedSizeList. We should exposed props to have better control over refs and avoid using internal api if it's not necessary.It works but we are using a readonly ref. If we set it byourselves we have complete access to it how we would like to initialise it and even what could be target outer element for the
FixedSizeList