perf: optimize byNeighborhoodSimilarity with degree pruning and allocation-free Jaccard#103
Open
sauravbhattacharya001 wants to merge 1 commit intomasterfrom
Open
perf: optimize byNeighborhoodSimilarity with degree pruning and allocation-free Jaccard#103sauravbhattacharya001 wants to merge 1 commit intomasterfrom
sauravbhattacharya001 wants to merge 1 commit intomasterfrom
Conversation
…ation-free Jaccard - Sort vertices by degree for effective upper-bound pruning - Break early when max possible Jaccard < threshold (sorted order guarantee) - Replace jaccardSimilarity's 2x HashSet allocation per call with jaccardFast that iterates smaller set and counts in larger (zero alloc) - Remove unused indexMap - Reduces O(V^2 * avg_degree) to O(V * effective_candidates * min_degree) with significant constant-factor improvement from avoiding GC pressure
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
\�yNeighborhoodSimilarity()\ in \GraphCompressor\ performs O(V²) pairwise Jaccard comparisons. Each \jaccardSimilarity()\ call allocates two new \HashSet\ objects (union + intersection), creating massive GC pressure on large graphs.
Changes
Degree-based upper-bound pruning: Vertices are sorted by degree. Since Jaccard(A,B) ≤ min(|A|,|B|)/max(|A|,|B|), once a vertex's degree ratio drops below the threshold, all subsequent vertices (with equal or larger degree) can be skipped entirely via \�reak.
Allocation-free Jaccard: New \jaccardFast()\ computes intersection by iterating the smaller set and checking membership in the larger one. Union = |A| + |B| - intersection. Zero intermediate \HashSet\ allocations.
**Removed unused \indexMap**: Was allocated but never read.
Performance Impact