fix: Cycle.equals() now distinguishes directed cycle direction#49
Open
sauravbhattacharya001 wants to merge 1 commit intomasterfrom
Open
fix: Cycle.equals() now distinguishes directed cycle direction#49sauravbhattacharya001 wants to merge 1 commit intomasterfrom
sauravbhattacharya001 wants to merge 1 commit intomasterfrom
Conversation
Previously, Cycle.equals() compared only the vertex *sets* of two cycles, meaning two directed cycles with the same vertices but different traversal orders (e.g., A→B→C→A vs A→C→B→A) would incorrectly be considered equal. This could cause the cycle enumeration to miss valid distinct cycles in directed graphs. Fixed by replacing the set-based comparison with a canonical rotation form: cycles are rotated so the lexicographically smallest vertex is first, then compared as ordered lists. This preserves rotation equivalence while correctly distinguishing different directions.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fix
Problem: CycleAnalyzer.Cycle.equals() compared only vertex sets, so two directed cycles with identical vertices but different traversal orders (e.g., A->B->C->A vs A->C->B->A) were incorrectly considered equal.
Fix: Replaced set-based comparison with canonical rotation form. Cycles are rotated so the lexicographically smallest vertex is first, then compared as ordered lists. Preserves rotation equivalence while distinguishing direction.
Impact: Directed graph cycle analysis now correctly identifies distinct cycles sharing the same vertex set.