fix: first row skipped in matchImei IMEI matching#57
Open
sauravbhattacharya001 wants to merge 1 commit intomasterfrom
Open
fix: first row skipped in matchImei IMEI matching#57sauravbhattacharya001 wants to merge 1 commit intomasterfrom
sauravbhattacharya001 wants to merge 1 commit intomasterfrom
Conversation
After rs_event.first() positions cursor on row 1, the while(rs_event.next()) loop immediately advances to row 2, causing the first matching row to be silently skipped. Same issue with rs_device.first() inside the inner loop. Fix: use beforeFirst() which positions cursor before row 1, so next() correctly processes row 1 first. This affected both sndrnode and srcnode matching blocks, meaning the first device match for each query was always missed.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
github-actions
bot
added
data-pipeline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
In \matchImei.java, both the sndrnode and srcnode matching loops skip the first result row due to an off-by-one error with JDBC cursor positioning.
Root Cause
\ResultSet.first()\ positions the cursor on row 1. The subsequent \while (rs_event.next())\ immediately advances to row 2, so row 1 is never processed. The same pattern occurs with
s_device.first()\ in the inner loop.
Fix
Replace \ irst()\ with \�eforeFirst(), which positions the cursor before row 1.