perf: use double instead of float for edge weights#87
Open
sauravbhattacharya001 wants to merge 1 commit intomasterfrom
Open
perf: use double instead of float for edge weights#87sauravbhattacharya001 wants to merge 1 commit intomasterfrom
sauravbhattacharya001 wants to merge 1 commit intomasterfrom
Conversation
The edge weight field was stored as float but every algorithm (Dijkstra, Louvain, ForceDirected, PageRank, etc.) operates on doubles internally. This caused implicit float-to-double widening on every getWeight() call in hot loops. Changes: - edge.java: weight field float -> double, getter/setter updated - GraphFileParser: Float.parseFloat -> Double.parseDouble for precision and to avoid widening on store - All existing float literal callers auto-widen safely (no source changes needed)
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Edge weight was stored as float but every algorithm operates on double internally, causing implicit widening on every getWeight() call in hot loops. Changes weight field to double and parser to Double.parseDouble.