perf: reduce computeStress() memory from O(V²) to O(V)#90
Open
sauravbhattacharya001 wants to merge 1 commit intomasterfrom
Open
perf: reduce computeStress() memory from O(V²) to O(V)#90sauravbhattacharya001 wants to merge 1 commit intomasterfrom
sauravbhattacharya001 wants to merge 1 commit intomasterfrom
Conversation
The previous implementation pre-computed all-pairs BFS shortest paths into a Map<String, Map<String, Integer>> before iterating over pairs. For a graph with V vertices this allocates V HashMap instances with up to V entries each, plus V² boxed Integer objects — all held in memory simultaneously. This change computes BFS one source vertex at a time and discards the distance map after processing, keeping only one BFS result alive at any point. The algorithmic complexity is unchanged (still O(V*(V+E))) but peak heap usage drops from O(V²) to O(V+E), which matters for graphs with thousands of nodes where the stress metric is most useful.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous implementation pre-computed all-pairs BFS shortest paths into a nested Map before iterating over pairs. For a graph with V vertices this allocates V HashMap instances with up to V entries each, plus V² boxed Integer objects — all held in memory simultaneously.
This change computes BFS one source vertex at a time and discards the distance map after processing, keeping only one BFS result alive at any point. The algorithmic complexity is unchanged (still O(V*(V+E))) but peak heap usage drops from O(V²) to O(V+E), which matters for graphs with thousands of nodes where the stress metric is most useful.
Automated gardening by Zalenix 🌱