refactor: use Map<EdgeType, List<edge>> in GraphStats constructor#96
Open
sauravbhattacharya001 wants to merge 1 commit intomasterfrom
Open
refactor: use Map<EdgeType, List<edge>> in GraphStats constructor#96sauravbhattacharya001 wants to merge 1 commit intomasterfrom
sauravbhattacharya001 wants to merge 1 commit intomasterfrom
Conversation
Replace the 5-parameter positional edge list constructor with a Map<EdgeType, List<edge>> variant. The old constructor is preserved as @deprecated for backward compatibility. Adds getEdges(EdgeType) accessor for type-safe edge queries. This makes the API cleaner and future-proof — adding a new edge type no longer requires changing the constructor signature.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the 5-parameter positional edge list constructor with a \Map<EdgeType, List>\ variant.
Changes
Why
The old constructor had 5 positional \List\ parameters — easy to mix up and requires signature changes whenever a new edge type is added. The map-based constructor is extensible and self-documenting.
🤖 Automated gardening by Zalenix