[codex] Add doctor live backend probes#93
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d642266ce2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| match from_env() { | ||
| Ok(config) => { | ||
| let label = format!("env:{}", env_type.as_deref().unwrap_or("?")); | ||
| runtime.block_on(probe_config(®istry, &label, &config, None)); |
There was a problem hiding this comment.
Pass a real path for env-based SSH probes
When ORBIT_BACKEND_TYPE is set, the env probe always calls probe_config(..., None), and probe_path_for turns that into an empty PathBuf for non-prefix backends (including SSH). In the SSH backend, list() forwards that path to sftp.readdir(path), so orbit doctor can report a list/not-found error even with valid SSH credentials simply because no probe path was provided. This creates a false-negative health check specifically for env-driven SSH setups unless users also pass an explicit --target ssh://.../path.
Useful? React with 👍 / 👎.
Summary
orbit doctorinto a command module and add repeatable--target <URI>live backend probes.ORBIT_BACKEND_TYPEis set.parse_uristores the URI path in the config.Validation
cargo fmtcargo auditcargo clippy --lib --features backend-abstraction -- -D warningscargo test --bin orbit doctor -- --nocapturecargo test --lib commands::doctor --all-features -- --nocapture