Skip to content

[codex] Add doctor live backend probes#93

Merged
saworbit merged 1 commit into
mainfrom
codex/doctor-live-backend-probes
May 18, 2026
Merged

[codex] Add doctor live backend probes#93
saworbit merged 1 commit into
mainfrom
codex/doctor-live-backend-probes

Conversation

@saworbit

Copy link
Copy Markdown
Owner

Summary

  • Move orbit doctor into a command module and add repeatable --target <URI> live backend probes.
  • Probe backend connectivity with a real list call, including env-backed backend config when ORBIT_BACKEND_TYPE is set.
  • Add prefix-safe probe path handling for backends where parse_uri stores the URI path in the config.
  • Document the feature in the changelog, getting started docs, quickstart guide, and v0.7 roadmap.

Validation

  • cargo fmt
  • cargo audit
  • cargo clippy --lib --features backend-abstraction -- -D warnings
  • cargo test --bin orbit doctor -- --nocapture
  • cargo test --lib commands::doctor --all-features -- --nocapture

@codecov

codecov Bot commented May 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 61.76471% with 91 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/commands/doctor.rs 62.28% 89 Missing ⚠️
src/main.rs 0.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@saworbit saworbit marked this pull request as ready for review May 18, 2026 07:22
@saworbit saworbit merged commit bdb8ffd into main May 18, 2026
11 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d642266ce2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/commands/doctor.rs
match from_env() {
Ok(config) => {
let label = format!("env:{}", env_type.as_deref().unwrap_or("?"));
runtime.block_on(probe_config(&registry, &label, &config, None));

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Pass a real path for env-based SSH probes

When ORBIT_BACKEND_TYPE is set, the env probe always calls probe_config(..., None), and probe_path_for turns that into an empty PathBuf for non-prefix backends (including SSH). In the SSH backend, list() forwards that path to sftp.readdir(path), so orbit doctor can report a list/not-found error even with valid SSH credentials simply because no probe path was provided. This creates a false-negative health check specifically for env-driven SSH setups unless users also pass an explicit --target ssh://.../path.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant