fix: filter of initial numeric values - #222
Merged
Merged
Conversation
Unfortunately, some tests for the filter lib are incorrectly setting initial values. The tests pass although there is a bug in the "empty filter". This fixes the "empty filter" so it correctly skips initial numeric values (i.e. `0`) and fixes the corresponding test cases.
Owner
|
Yeah, a subtle bug. Thanks. |
Contributor
Author
|
Null doesn’t mean “nothing” like an empty string (""), an empty array ([]), or an empty object ({}), but rather “no value”. I would keep it. |
Contributor
Author
|
Closes #121 |
Contributor
Author
|
Can we merge this since it's blocking an abapgit fix? |
Owner
|
Yes, merged. Thanks for the fix. P.S. still in doubt about the "null" but as it worked the same before, so not a regression anyway. Let's keep as it is now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately, some tests for the filter lib are incorrectly setting initial values. The tests pass although there is a bug in the "empty filter".
This fixes the "empty filter" so it correctly skips initial numeric values (i.e.
0) and fixes the corresponding test cases.