Skip to content

Fix typos and improve diagnostic messages for pd10129, pd10130, pd10141 #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Drishti160803 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix typos and improve diagnostic messages for pd10129, pd10130, pd10141 #75

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions validation/rules/sbgn_pd.sch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,7 +444,7 @@ Schematron validation for SBGN PD
see="sbgn-pd-L1V1.3-3.5.1-1"
role="error"
test="count(../../sbgn:port/sbgn:state[@variable = current()/@variable]) <= 2"
diagnostics="id">All state variables associated with a Stateful Entity Pool Node should be unique and note duplicated within that node.
diagnostics="id">All state variables associated with a Stateful Entity Pool Node should be unique and not duplicated within that node. Found duplicate state variable '<iso:value-of select="@variable"/>' on node '<iso:value-of select="../../@id"/>'.
</iso:assert>
</iso:rule>
</iso:pattern>
Expand All @@ -458,7 +458,7 @@ Schematron validation for SBGN PD
name="subunit-mod-arc-source"
role="error"
test="@class = 'modulation'"
diagnostics="id class">[NOT SURE]
diagnostics="id class">An arc connecting to a subunit of a complex must be of class 'modulation'. Arc '<iso:value-of select="@id"/>' has class '<iso:value-of select="$class"/>' which is not allowed here.
</iso:assert>
</iso:rule>
</iso:pattern>
Expand Down Expand Up @@ -594,7 +594,7 @@ Schematron validation for SBGN PD
see="sbgn-pd-L1V1.3-3.5.2.1-1"
role="error"
test="($count &gt;= 2)"
diagnostics="id count">All process nodes should have at least one input and at least one ouput pointing to the arcs
diagnostics="id count">Process node '<iso:value-of select="@id"/>' must have at least one input arc (consumption) and at least one output arc (production) connected to its ports. Found <iso:value-of select="$count"/> arc(s) — at least 2 are required.
</iso:assert>
</iso:rule>
</iso:pattern>
Expand Down