Skip to content
This repository was archived by the owner on Dec 19, 2023. It is now read-only.

Fix for PHP 7 compatibility#102

Open
skeyby wants to merge 21 commits intosbisbee:masterfrom
skeyby:master
Open

Fix for PHP 7 compatibility#102
skeyby wants to merge 21 commits intosbisbee:masterfrom
skeyby:master

Conversation

@skeyby
Copy link

@skeyby skeyby commented Oct 27, 2017

We recently updated our machines to PHP 7.1 and the code got stuck in the fgets because it was failing to understand that the transfer was chunked.

We did a side by side trace with PHP 5.6 and found this line to behave differently.

Now it's working ok.

@kyoun8
Copy link

kyoun8 commented Dec 2, 2017

Hi, i had a similar issue on php7 and on the file: sagCurlHTTPAdaptater.php,
fixed on line 124, by replacing
$response->headers->$line[0] = ltrim($line[1]);
by
$response->headers->{$line[0]} = ltrim($line[1]);

@boussou
Copy link

boussou commented Oct 4, 2020

@skeyby do you still maintain your own version?

@skeyby
Copy link
Author

skeyby commented Oct 5, 2020 via email

@boussou
Copy link

boussou commented Oct 5, 2020

Ok, I forked your project, and indeed your change is mandatory on PHP 7.x.
So I consider your repo as master - is more up to date.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants