Add tune set grouping to the repertoire grid

[sboagy]

Summary

• add reusable mixed tune/set hierarchy helpers for grid rows so tune-set grouping lives at the TunesGrid layer instead of only in the repertoire route
• render repertoire tunes as expandable set containers in both grid and list views, including visible set-row styling
• fix bulk-selection semantics by using flattened selected rows so tunes that already appear inside a set can still be saved into another set

What changed

• added grouped-grid-rows.ts to build mixed tune/set rows, row ids, subrow access, and row-selection rules for hierarchical tune grids
• extended TunesGrid with reusable hierarchy support: expandable rows, row id/subrow hooks, auto-expanded parents, hierarchy-aware list data, and set-row styling
• updated TuneStackedList to support hierarchical rows in list mode so the Display Options toggle works again for repertoire
• updated TunesGridRepertoire to fetch visible tune sets and tune-set items, then build mixed tune/set rows for the repertoire tab
• updated repertoire selection consumers to use getSelectedRowModel().flatRows and dedupe on tune_id ?? id
• updated bulk goal apply in the repertoire route to use flattened selected rows as well
• added focused unit coverage for the mixed row builder search and grouping behavior

User-visible behavior

• tunes that belong to visible sets now appear under expandable set rows in the repertoire tab
• list view and grid view both preserve the hierarchy
• set rows are visually distinct from regular tune rows
• selecting a tune from within an existing set no longer prevents saving that tune to another set

Validation

• npx vitest run tests/components/grids/grouped-grid-rows.test.ts
• npx tsc -p tsconfig.app.json --noEmit
• user-confirmed broader validation later in session: npm run lint && npm run check && npm run typecheck && npm run test:unit

Notes

• this is the repertoire-tab portion of issue Add grouping by Tune Set to tune grids and sets #570, with the hierarchy work pushed down so the future SetlistsGrid can reuse it

[Copilot]

Pull request overview

Adds hierarchical Tune Set grouping to the Repertoire tunes grid/list by introducing a mixed tune + tune-set row model (expandable parents with subrows), updating selection semantics to work with duplicated tunes, and wiring the repertoire tab to fetch visible sets + items.

Changes:

• Added grouped-grid-rows.ts helpers to build mixed tune/tune-set rows (row ids, subrows, selection rules, auto-expand IDs).
• Extended TunesGrid + TuneStackedList to render expandable hierarchical rows in both grid and list modes, with set-row styling.
• Updated repertoire selection consumers to use getSelectedRowModel().flatRows and dedupe tune IDs for bulk actions.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
tests/components/grids/grouped-grid-rows.test.ts	Adds unit tests for mixed row building / grouping / search behavior.
src/routes/repertoire.tsx	Switches bulk selection semantics to flattened selected rows.
src/components/repertoire/RepertoireToolbar.tsx	Uses flattened selected rows and deduped tune IDs for toolbar actions.
src/components/grids/TuneStackedList.tsx	Adds list-mode hierarchy rendering (indentation + expand/collapse UI) and selection gating.
src/components/grids/TunesGridRepertoire.tsx	Fetches visible tune sets + items and builds mixed hierarchical rows for the repertoire tab.
src/components/grids/TunesGrid.tsx	Adds TanStack expanding/subrows support, hierarchy cell rendering, list-mode expansion wiring, and set-row styling.
src/components/grids/grouped-grid-rows.ts	Implements the reusable mixed tune/tune-set row builder and helper accessors.

Comments suppressed due to low confidence (1)

src/components/grids/TunesGrid.tsx:642

• In list mode, row-selection state is keyed by TanStack row IDs (including compound IDs for subrows), but this handler uses String(row.id) which is the tune/set id from the original data. For hierarchical rows this will (a) fail to toggle selection for subrows and (b) collide when the same tune appears under multiple sets. Use row.stacked_row_id (added in stackedListData) as the selection key (fallback to row.id only if needed).

  const handleStackedRowSelectionChange = (
    row: IStackedListRow,
    checked: boolean
  ) => {
    const rowId = String(row.id);

[Copilot]

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.

[sboagy]

@copilot apply changes based on the comments in this thread

[Copilot]

@copilot apply changes based on the comments in this thread

Done in commit 7bac9db.

repertoire.tsx N+1 fix — both selectedTuneSetTuneIds and anyTuneSetTuneIds resources now use getBatchedTuneSetItemRefs instead of getTuneIdsForTuneSets. This replaces the per-set getTuneSetAccessForUser + item fetch + per-item getTuneRow chain with a single SELECT tuneSetRef, tuneRef, position ... WHERE tuneSetRef IN (...) query; unique tune IDs are then collected client-side with new Set().

TuneStackedList.tsx non-unique DOM ID fix — data-testid on the <li> element now uses rowId (the TanStack row ID, e.g. set-{setId}-tune-{tuneId}) instead of itemId (tune_id ?? id). When the same tune appears in multiple sets, itemId was identical for both rows making the testid non-unique. rowId is always unique. isSelected() continues using itemId since current-tune selection is by tune identity.