Update SQLite to version 3.53.2#96
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the vendored SQLite sources in CSQLite to upstream SQLite 3.53.2, aligning the amalgamation (sqlite3.c) and public header (sqlite3.h) version metadata and incorporating upstream fixes/changes across the core and extensions.
Changes:
- Bump SQLite version macros/source identifiers to 3.53.2 in both the amalgamation and public header.
- Pull in upstream SQLite 3.53.2 amalgamation changes (session/changeset apply behavior updates, robustness/corruption checks, JSON/FTS/rtree fixes, etc.).
- Update the
seriesextension edge-case handling for float boundary computations.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
Sources/CSQLite/sqlite3.c |
Upstream 3.53.2 amalgamation refresh + new constants and many internal fixes/robustness changes. |
Sources/CSQLite/series.c |
Adjust float-to-int boundary math for value >/>= X and value </<= X constraints. |
Sources/CSQLite/include/sqlite3.h |
Update public version macros and add the new SQLITE_CHANGESETAPPLY_NOUPDATELOOP flag constant/docs. |
Comments suppressed due to low confidence (1)
Sources/CSQLite/sqlite3.c:53428
- In winShmMap(), iOffset was changed to i64, but the subsequent OSTRACE() call still uses the "%d" format specifier for offset. This is a varargs type mismatch and can cause undefined behavior (especially on 64-bit builds) when tracing is enabled.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.